Closed woshilapin closed 4 days ago
Note: the Station that appears in the tab for scheduled stops, is expected (even if it's surprising in terms of User Experience). When launching a pathfinding, the response will contain all Operational points on the way (the station is an Operational Point). I tested the functionality of 'arrival on stop signal' for Operational Point, and it works as expected. So only via seems to create problems with my video-recorded scenario.
For the issue concerning the number of operational points listed in the times and stops table, we only have two because it only shows the via added on the map and the existing operational points in this path. When origin and/or destination are added by click on map (so not from an op on the path), we should add them to the list in the times and stops table.
@woshilapin would you mind to retest the app regarding the issue to check if all your concerns have been resolved to close it ? :) (except the input table issue reported here : https://github.com/OpenRailAssociation/osrd/issues/8019)
So I tried a similar scenario (without the via) and got a whole lot of other weird behaviors. I had to test on rec
since dev
was broken. Here is the video and a list below.
https://github.com/user-attachments/assets/2e7322c7-d942-406d-9728-1b4560894b24
Scenario (see in bold all the unexpected behavior):
Probably most of your issues will be fixed with this PR.
So as tested yesterday, much less is happening. There is still some ordering problems in the scheduled stops when suppressing one of them. See the following video.
https://github.com/user-attachments/assets/8b5b7780-bbf2-4910-8834-919a3db4e574
This PR would fix the problem when clicking on the cross in the video
@woshilapin, can you check if this ticket should be closed?
Last scenario tested again. Looks good. The constraints are now deleted when clicking on the red cross, without weird reordering of scheduled points, and the path is drawn correctly on the map. Note that the via is still preserved (not sure if it should be considered as a constraint that should also disappear too, but we can re-open a bug later it this starts to be a valid use case). I'm closing the ticket.
What happened?
Multiple different bugs happened in a relatively simple scenario. See the video and the description.
https://github.com/OpenRailAssociation/osrd/assets/2520723/204180e9-9bb9-4208-b957-8aaae355421c
What did you expect to happen?
How can we reproduce it (as minimally and precisely as possible)?
Here's a video to reproduce the steps. The TSV2 and new STDCM features are activated in the user profile.
https://github.com/OpenRailAssociation/osrd/assets/2520723/204180e9-9bb9-4208-b957-8aaae355421c
What operating system, browser and environment are you using?
OSRD version (top right corner
Account
button >Informations
)625d185