Closed Erashin closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.67%. Comparing base (
22d010d
) to head (5acf0be
). Report is 25 commits behind head on dev.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
TBD: probably a regression on potentially infinite remaining time (use max with max running time). Also not sure about the default value to 0.0 in STDCMNode.remainingTime, could actually be Double.Infinity.
Exiting early should be mostly straightforward, like if (node.timeSinceDeparture + node.remainingTimeEstimation > maxRunTime) return null
just after getting a node. We don't have the time since departure yet, but we already need to add it for other reasons
Also not sure about the default value to 0.0 in STDCMNode.remainingTime, could actually be Double.Infinity.
We shouldn't have no value there. Ideally there shouldn't be any default value, or null if we can't have it when initializing (with !!
when getting the value).
If we do want a default value, it should be optimistic (i.e. 0)
Fixes #7581 and #7582.