search

OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
GNU Lesser General Public License v3.0
419 stars 40 forks source link

gateway: fix gateway amr #7852

Closed ElysaSrc closed 2 weeks ago

ElysaSrc commented 2 weeks ago

Fixes issue with Gateway default value on amr

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 18.54%. Comparing base (6453143) to head (449932f). Report is 12 commits behind head on dev.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation: There is a different number of reports uploaded between BASE (6453143) and HEAD (449932f). Click for more details.

HEAD has 10 uploads less than BASE | Flag | BASE (6453143) | HEAD (449932f) | |------|------|------| |railjson_generator|3|1| |gateway|3|1| |tests|3|1| |core|3|1| |front|3|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #7852 +/- ## ============================================= - Coverage 28.68% 18.54% -10.15% - Complexity 2058 2060 +2 ============================================= Files 1249 974 -275 Lines 154454 125157 -29297 Branches 3041 3041 ============================================= - Hits 44307 23209 -21098 + Misses 108333 100134 -8199 Partials 1814 1814 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.96% <ø> (-0.03%)` | :arrow_down: | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `?` | | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `10.01% <ø> (-0.01%)` | :arrow_down: | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.34% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ElysaSrc commented 2 weeks ago

Should not be required, was an issue locally with something else unrelated.