Open Yohh opened 3 months ago
Since things moved a lot since this ticket was opened, here is the updated list of remaining TODOs.
The following TODOs are the ones that are isolated and could (and should, I think) be solved as soon as we can:
// TODO: ATM we don't know if a selected speed section should be considered as SpeedSection or PSL
// TODO: should we display it ?
// TODO: Should we display the resize error ?
// TODO - add TVM300 and TVM430 tests
// TODO : Would be better and safer if editoast was sending this type in the getSwitchTypes endpoint so we can remove all related types
// TODO : Rename all switch by tracknode when back renaming PR merged
// TODO : remove electrical profiles
// TODO: check that the trainrunSections format is still compatible
// TODO: extract isNonStopTransit from transitions
// TODO: save position for nodes without trigram too
// TODO: make this optional in NGE since it's SBB-specific
// TODO: find a better way to hide this in the graph
// TODO: grab NGE component size
// TODO: Add RC information when it becomes avalaible, until that, we use fake ones
{/* TODO: Add path number and date from reference path when it becomes avalaible */}
{/* TODO: Add path number and date from reference path when it becomes avalaible */}
/** TODO The number must be calculated from a hash of stdcm inputs (to have a stable number).
// TODO: DROP STDCM V1: remove formattedStartTime, startTime and latestStartTime
{/* TODO: use RTK request status */}
// TODO: DROP STDCMV1: set those values by default in the store when <StdcmAllowances/> is not used anymore.
{/* //TODO: use them when we implement this feature #403 */}
// TODO: Find a better way to prevent user from entering decimal values
// TODO: find a better way to do this when ui-core suggestion component is implemented
{/* TODO: remove the disabling on buttons when functional */}
// TODO : refacto. state useStdcm. Maybe we can merge some state together in order to reduce the number of refresh
// TODO AUTH:
// TODO AUTH:
* TODO: cases on extremities
// TODO: an impovment can be to take the one in the middle if there are many
* TODO: need to be check and tested (specially the underlying update function)
// TODO use the frag tool context here
// TODO: should we display it ?
// TODO: we abuse the PathStep.id field here, the backend also sets it to an
// TODO: step offset should be in mm in the store /!\
// TODO: we should return the offset in mm once it is stored in mm in the store
// TODO: we should return the offset in mm once it is stored in mm in the store
// TODO : convert begin and end in meters here instead of in PowerRestrictionsSelector
// TODO: remove this line in the type
// TODO: remove this line in the type
// TODO: make the conditional return clearer
// TODO: investigate if the main condition does not have bad side effects
// TODO: use ScenarioCreateForm from osrdEditoastApi to harmonize with study and project
* @TODO do not work with colors as string as soon as possible
// TODO use lodash pick
// TODO: move this hook in Timetable
// TODO rename setLoading, setSucess with more meaningful names like pushLoadingNotification, pushSucessNotification, ...
// TODO Need this with routing ?
// TODO: Change the type of duration to number. It is preferable to keep this value in seconds in the store
// TODO TS2 : Next part might not be needed (except to updePathSteps), we need inly trainSchedulePath and
// TODO TS2 : test errors display after core / editoast connexion for pathProperties
// TODO TS2 : test this hook in simulation results issue
// TODO TS2 : when adapting train update check that this computation works properly
// TODO TS2: rename ManageTrainSchedulePathProperties and move it to /modules/pathfinding
// TODO TS2 : remove this when rollingStockName will replace rollingStockId in the store
{/* TODO TS2 : rename trainScheduleDepartureTime key to trainScheduleStartTime everywhere */}
// TODO TS2 : remove this when rollingStockName will replace rollingStockId in the store
I think the following TODOs could be ignored, since they relate to the old version of the WarpedMap, that has been reimplemented since in the OSRD-UI project:
// TODO: Detect loops and remove them from the simplifiedPath
// TODO: fix warped map - pass the selected train simulation results (SimulationResponseSuccess) in props
// TODO: fix warped map - uncomment the next commented lines
// TODO: fix warped map - adapt this part with simulations results
// TODO: fix warped map - adapt this part with simulations results
// TODO: fix warped map - probably remove this from props
// TODO: fix warped map - check if this is the correct data type to use
// TODO: fix warped map - probably remove this function and use finalOutput as key ?
// TODO: fix warped map - check if this is the correct data to use
// TODO: fix warped map - check if we need to adapt these values with tsv2 datas
// TODO: fix warped map - uncomment and adapt all the rest of the funtion
// TODO: fix warped map - probably remove this from props (and delete the AllowancesSettings type)
// TODO: fix warped map - adapt this test
These TODOs should be fixed once we fully migrate to ui-core:
// TODO Remove this after the fix in the ui-core
// TODO: remove this style after ui-core component is implemented
/*TODO Waiting to fix the button in ui-core...*/
These TODOs seem to be related to the recent/current migrations to the new GET and GEV:
// TODO GET v2 : probably remove this conversion as trains will travel on several days
// TODO: feed the spaceTimeChart with date instead of formatted string
// TODO: remove this when spaceCurvesSlopes chart will be deleted
// TODO: remove this when spaceCurvesSlopes chart will be deleted
// TODO: remove this when spaceCurvesSlopes chart will be deleted
// TODO: remove this when enableInteractivity will be deleted
// TODO: remove this when spaceCurvesSlopes chart will be deleted
// TODO GET v2 : probably remove this conversion as trains will travel on several days
// TODO GET v2 : probably remove this conversion as trains will travel on several days
// TODO: remove this when spaceCurvesSlopes chart will be deleted
Description and goal
we have a hundred TODO comments in front/src half are tagged
TS2
orDROP V1
and will be managed during the PI11 half are sometimes 15 months old we have to managed those old TODOsAcceptance criteria
DROP V1
TS2
OTHERS