search

OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
GNU Lesser General Public License v3.0
415 stars 40 forks source link

Fix large uri for batch retrieve train schedules #7881

Closed flomonster closed 3 days ago

flomonster commented 6 days ago

close #7860

Browser have a URI length limit:

The idea is to move query parameters to the body of the request.

[!NOTE] This implies moving GET endpoint to POST.

Which endpoint is involved:

codecov-commenter commented 6 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.65854% with 38 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (028ae7b) to head (e6f1db9). Report is 1 commits behind head on dev.

Files Patch % Lines
...ules/trainschedule/components/TimetableV2/hooks.ts 0.00% 9 Missing :warning:
editoast/src/views/v2/train_schedule/projection.rs 30.00% 7 Missing :warning:
...rationalStudies/views/v2/getSimulationResultsV2.ts 0.00% 6 Missing :warning:
front/src/config/openapi-editoast-config.ts 0.00% 6 Missing :warning:
editoast/src/views/v2/train_schedule.rs 66.66% 5 Missing :warning:
front/src/common/api/generatedEditoastApi.ts 90.62% 3 Missing :warning:
...le/components/TimetableV2/TimetableTrainCardV2.tsx 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #7881 +/- ## ============================================ - Coverage 28.55% 28.54% -0.02% Complexity 2059 2059 ============================================ Files 1249 1249 Lines 154210 154182 -28 Branches 3036 3036 ============================================ - Hits 44028 44004 -24 + Misses 108372 108368 -4 Partials 1810 1810 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.95% <ø> (ø)` | | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.66% <52.00%> (-0.02%)` | :arrow_down: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `10.00% <54.38%> (-0.01%)` | :arrow_down: | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.34% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7881/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.