search

OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
GNU Lesser General Public License v3.0
415 stars 40 forks source link

front: rename variable from French to English #7893

Closed turnerian2004 closed 2 days ago

turnerian2004 commented 4 days ago

Resolves #7891

emersion commented 3 days ago

Thanks for submitting a pull request!

The idea looks good, but I wonder if searchRollingStock, searchStock or just search would be a better pick? We use the term "rolling stock" as the translation of the French word "matériel roulant". It should be clear enough from the function name useFilterRollingStock() that this is about rolling stocks (and most other variable names don't have "rolling stock" in their name).

What do you think?

turnerian2004 commented 3 days ago

Thanks for submitting a pull request!

The idea looks good, but I wonder if searchRollingStock, searchStock or just search would be a better pick? We use the term "rolling stock" as the translation of the French word "matériel roulant". It should be clear enough from the function name useFilterRollingStock() that this is about rolling stocks (and most other variable names don't have "rolling stock" in their name).

What do you think?

Thank you, Emersion, for the warm welcome and the translation explanation.

Yes, I agree with you that searchMaterial is not the best variable name. My vote is for searchStock, since that seems to most adhere to the codebase naming convention & provides more clarity than search.

emersion commented 3 days ago

Works for me!

turnerian2004 commented 2 days ago

Hi SharglutDev! Thank you, also, for the warm welcome.

I started to type a reply to your comment but fell asleep before the posting the comment and the pr was merged lol

turnerian2004 commented 2 days ago

Hi SharglutDev! Thank you, also, for the warm welcome.

I started to type a reply to your comment but fell asleep before the posting the comment and the pr was merged lol

@SharglutDev 😊😊😊

SharglutDev commented 2 days ago

Haha don't worry, thank you again for contributing, don't work too much !