OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
GNU Lesser General Public License v3.0
415 stars 40 forks source link

Isolate editoast search engine into a dedicated crate #7906

Open leovalais opened 3 days ago

leovalais commented 3 days ago

Since the incremental computing prototype is postponed, we might as well do this now.

codecov-commenter commented 3 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 43.25843% with 101 lines in your changes missing coverage. Please review.

Project coverage is 28.46%. Comparing base (7353c7a) to head (4167ebc). Report is 15 commits behind head on dev.

Files Patch % Lines
editoast/editoast_search/src/lib.rs 0.00% 54 Missing :warning:
editoast/editoast_search/src/dsl.rs 47.50% 21 Missing :warning:
editoast/src/views/search.rs 40.00% 12 Missing :warning:
editoast/editoast_search/src/context.rs 58.82% 7 Missing :warning:
editoast/editoast_derive/src/search.rs 86.36% 3 Missing :warning:
editoast/editoast_search/src/searchast.rs 77.77% 2 Missing :warning:
editoast/editoast_search/src/process.rs 90.00% 1 Missing :warning:
editoast/editoast_search/src/typing.rs 83.33% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #7906 +/- ## ============================================ - Coverage 28.54% 28.46% -0.08% Complexity 2059 2059 ============================================ Files 1249 1254 +5 Lines 154182 154578 +396 Branches 3036 3047 +11 ============================================ - Hits 44009 44000 -9 - Misses 108363 108763 +400 - Partials 1810 1815 +5 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `75.00% <ø> (+0.04%)` | :arrow_up: | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.37% <43.25%> (-0.31%)` | :arrow_down: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `9.97% <ø> (-0.03%)` | :arrow_down: | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.34% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7906/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.