OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
GNU Lesser General Public License v3.0
415 stars 40 forks source link

front: fix via modal display #7910

Closed SarahBellaha closed 1 day ago

SarahBellaha commented 2 days ago

Closes #7886

codecov-commenter commented 2 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.53%. Comparing base (7353c7a) to head (ffbf2d3). Report is 1 commits behind head on dev.

Files Patch % Lines
...inding/components/Itinerary/ModalSuggestedVias.tsx 0.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #7910 +/- ## ============================================ - Coverage 28.54% 28.53% -0.01% Complexity 2059 2059 ============================================ Files 1249 1249 Lines 154182 154184 +2 Branches 3036 3036 ============================================ - Hits 44009 44004 -5 - Misses 108363 108370 +7 Partials 1810 1810 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.95% <ø> (ø)` | | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.66% <ø> (-0.02%)` | :arrow_down: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `10.00% <0.00%> (-0.01%)` | :arrow_down: | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.34% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7910/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theocrsb commented 2 days ago

thank you for your PR. behavior is fixed for some names but some still have weird behavior

image

Yohh commented 2 days ago

thank you for your PR. behavior is fixed for some names but some still have weird behavior

image

nothing like that for me, did your switch work? are you really on the sba/front/fix-via-modal-7886 branch?

theocrsb commented 2 days ago

thank you for your PR. behavior is fixed for some names but some still have weird behavior image

nothing like that for me, did your switch work? are you really on the sba/front/fix-via-modal-7886 branch?

My bad. I tried again and it's ok. maybe switch doesn't work.