OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
GNU Lesser General Public License v3.0
415 stars 40 forks source link

Set editoast tokio flavor multi-thread #7924

Closed flomonster closed 2 days ago

flomonster commented 2 days ago

Tokio doc: https://docs.rs/tokio/latest/tokio/attr.main.html#multi-threaded-runtime

[!NOTE] When printing the flavor in the main we have MultiThread instead of CurrentThread. However we still observe CurrentThread when printing inside an endpoint.

flomonster commented 2 days ago

That sounds like an incredibly simple yet perfect solution

This does not fix the usage of join_all futures.

codecov-commenter commented 2 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.45%. Comparing base (d6f255b) to head (30d3cbc). Report is 4 commits behind head on dev.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #7924 +/- ## ============================================ - Coverage 28.48% 28.45% -0.04% Complexity 2059 2059 ============================================ Files 1254 1256 +2 Lines 154469 154592 +123 Branches 3047 3049 +2 ============================================ - Hits 44007 43993 -14 - Misses 108647 108782 +135 - Partials 1815 1817 +2 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `75.00% <ø> (ø)` | | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.60% <ø> (-0.07%)` | :arrow_down: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `9.96% <ø> (-0.02%)` | :arrow_down: | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.34% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/7924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ElysaSrc commented 2 days ago

That sounds like an incredibly simple yet perfect solution

This does not fix the usage of join_all futures.

My bad, I thought it would.