Closed hamz2a closed 5 days ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 82.45614%
with 30 lines
in your changes missing coverage. Please review.
Project coverage is 28.21%. Comparing base (
bea5cee
) to head (6b5fd5a
). Report is 7 commits behind head on dev.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm curious about why we do need a lot of
#[serial_test::serial]
in commit 3040c34.
I added #[serial_test::serial]
because I was getting deadlock errors.
I'm curious about why we do need a lot of
#[serial_test::serial]
in commit 3040c34.I added
#[serial_test::serial]
because I was getting deadlock errors.
We dug a little bit to try to understand. It's a deadlock detected by the Postgresql instance itself. It might be due to concurrence on the generated id for infras since we do create very long transactions when working with infras in tests.
We did not find an obvious solution to work around the problem. Let's keep it like this.
Part of https://github.com/OpenRailAssociation/osrd/issues/6980
It's better to review the PR commit by commit. I created intermediate functions
{function}_v2
to facilitate the migration, but I deleted everything at the end.I also refactored
persist_railjson
to useDbConnection
directly instead ofDbConnectionPool
. Consequently, I removed the macropersist!
that was in there andfutures::try_join!
, and I added a transaction.