Closed Castavo closed 3 days ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 28.27%. Comparing base (
b05d26f
) to head (1848027
).
Files | Patch % | Lines |
---|---|---|
editoast/src/views/v2/train_schedule.rs | 0.00% | 6 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Would not work since 500 errors could come from core but also from diesel for example...
When
core.fetch
returns an Error made from a 500 from core,train_simulation
returnsOk(SimulationResponse::SimulationFailed)
rather than anError
.This allows to still be able to call
train_schedule/simulation_summary
when one of the trains leads to an error in core (an assert error for example).I left other error status codes fail because they'll likely be transient, what do you think ?