Closed anisometropie closed 1 month ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 48.15618%
with 239 lines
in your changes missing coverage. Please review.
Project coverage is 37.05%. Comparing base (
2d6138c
) to head (143da9a
). Report is 4 commits behind head on dev.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When I try to add 1 hour to 23 hours the requested departure time is not displayed. It is displayed when it is not midnight.
I don't know if this use case should be possible, but when I try to start the train 2 days later (172800 seconds), the requested departure time only shows J+1.
I don't know if this use case should be possible, but when I try to start the train 2 days later (172800 seconds), the requested departure time only shows J+1.
It’s not a case we currently choose to handle
TBH I am not a huge fan of these new types which don't improve type safety (since they're aliases)…
TBH I am not a huge fan of these new types which don't improve type safety (since they're aliases)…
I agree but it doesn't add to much logic in the code. When the refacto for that will be done it can be adapted ? Or do you prefer to keep string
everywhere in the meantime ?
TBH I am not a huge fan of these new types which don't improve type safety (since they're aliases)…
@emersion
They are meant to define clearly what they are, and give move details when you hover your mouse over them.
I don’t want to lose the info and go back to a string
. they can easily be changed with better types if we know where they are
closes #7781
We now use a different format to represent
arrival
anddeparture
inSuggestedOP
andPathStep
, an ISO duration string. The previous time string format hh:mm:ss was insufficient for distinguishing times spanning more than 24 hoursThese two types are used in different places beyond the scope of just the input/outpt, we should test everything that uses these two types