OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
436 stars 40 forks source link

front: upgrade NGE to forked v2.7.2 #8343

Closed emersion closed 1 month ago

emersion commented 1 month ago

We maintain a fork of NGE with some custom patches: https://github.com/osrd-project/netzgrafik-editor-frontend/tree/standalone

Our fork includes patches that aren't yet ready to be upstreamed, or cannot be upstreamed at all. For instance, hiding the return travel for trains (making them one-way) will require a much larger refactoring to be supported upstream. Some features like saved filters could in theory be supported but as-is will be lost on page reload.

Unfortunately this means we're back to the @osrd-project namespace for now.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 37.95%. Comparing base (6585f91) to head (e737f15). Report is 1 commits behind head on dev.

Files Patch % Lines
.../operationalStudies/components/MacroEditor/NGE.tsx 0.00% 6 Missing :warning:
...perationalStudies/components/MacroEditor/import.ts 0.00% 1 Missing :warning:
...operationalStudies/components/MacroEditor/types.ts 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #8343 +/- ## ============================================ - Coverage 37.96% 37.95% -0.01% Complexity 2163 2163 ============================================ Files 1248 1248 Lines 114978 114978 Branches 3137 3137 ============================================ - Hits 43655 43645 -10 - Misses 69473 69483 +10 Partials 1850 1850 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `75.59% <ø> (ø)` | | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `66.84% <ø> (-0.04%)` | :arrow_down: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.35% <0.00%> (ø)` | | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.03% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8343/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

emersion commented 1 month ago

Ref https://github.com/OpenRailAssociation/osrd/issues/8349 for more details about the fork.

Changes with this new version:

emersion commented 1 month ago

Upgraded the fork again, changes:

emersion commented 1 month ago

Sorry - I just pushed a small fix for the auto dark theme which doesn't look great inside OSRD. Do you want me to fill that as a separate PR, or is this fine?

louisgreiner commented 1 month ago

Tested after last fix, looks good to me