search

OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
436 stars 40 forks source link

refacto: core: rename occurences of "x/y" to "latitude/longitude" #8346

Closed eckter closed 3 weeks ago

eckter commented 1 month ago

Fix https://github.com/OpenRailAssociation/osrd/issues/8344

3 parts and 3 commits:

  1. Remove what should be the last occurrence of cartesian maths
    1. Doesn't fix the one in https://github.com/OpenRailAssociation/osrd/issues/8215 as it will be in another PR, but it's commented
    2. Includes test updates, as this slightly changes the results
  2. Rename "x" and "y" to "longitude" and "latitude"
  3. Swap longitudes and latitudes in parameter orders (lat/lon is more common than lon/lat)
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes missing coverage. Please review.

Project coverage is 37.95%. Comparing base (ef77780) to head (4fd0a24). Report is 72 commits behind head on dev.

Files Patch % Lines
...om/src/main/java/fr/sncf/osrd/geom/LineString.java 90.00% 1 Missing and 4 partials :warning:
.../fr/sncf/osrd/api/api_v2/pathfinding/DebugUtils.kt 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #8346 +/- ## ========================================= Coverage 37.94% 37.95% + Complexity 2163 2162 -1 ========================================= Files 1248 1248 Lines 114950 114948 -2 Branches 3135 3135 ========================================= + Hits 43623 43633 +10 + Misses 69479 69467 -12 Partials 1848 1848 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `75.58% <89.65%> (-0.01%)` | :arrow_down: | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `66.84% <ø> (+0.04%)` | :arrow_up: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.35% <ø> (ø)` | | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.03% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.