codecov-commenter
commented
1 month ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
Project coverage is 36.98%. Comparing base (
58dcca9) to head (ac6f7fa). Report is 18 commits behind head on dev.
| Files | Patch % | Lines |
|---|---|---|
| ...main/java/fr/sncf/osrd/geom/WGS84Interpolator.java | 91.66% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #8353 +/- ## ============================================ - Coverage 36.98% 36.98% -0.01% - Complexity 2167 2168 +1 ============================================ Files 1271 1272 +1 Lines 118002 118015 +13 Branches 3172 3172 ============================================ + Hits 43645 43648 +3 - Misses 72483 72493 +10 Partials 1874 1874 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.92% <93.75%> (+0.01%)` | :arrow_up: | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `66.30% <ø> (-0.03%)` | :arrow_down: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `15.95% <ø> (ø)` | | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.20% <ø> (ø)` | | | [osrdyne](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.71% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.91% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix https://github.com/OpenRailAssociation/osrd/issues/8215
There's a refacto on the same branch that should be merged first (see https://github.com/OpenRailAssociation/osrd/pull/8346)
Note that it doesn't fix all geo issues, but I don't think the other ones are directly related. The path is now perfectly aligned with track sections, but there's still issues with start/end points:
I have a feeling the issue https://github.com/OpenRailAssociation/osrd/issues/6076 is somehow related.