OpenRailAssociation / osrd

An open source web application for railway infrastructure design, capacity analysis, timetabling and simulation
https://osrd.fr
436 stars 40 forks source link

editoast: add roles check to `views::infra` part 2 #8361

Closed hamz2a closed 1 month ago

hamz2a commented 1 month ago
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.89655% with 50 lines in your changes missing coverage. Please review.

Project coverage is 38.43%. Comparing base (ef77780) to head (6c89a09). Report is 2 commits behind head on dev.

Files Patch % Lines
editoast/src/views/infra/routes.rs 50.00% 13 Missing :warning:
editoast/src/views/infra/edition.rs 41.17% 10 Missing :warning:
editoast/src/views/infra/pathfinding.rs 0.00% 9 Missing :warning:
editoast/editoast_authz/src/builtin_role.rs 0.00% 4 Missing :warning:
editoast/src/views/infra/railjson.rs 77.77% 4 Missing :warning:
editoast/src/views/infra/attached.rs 75.00% 2 Missing :warning:
editoast/src/views/infra/auto_fixes/mod.rs 75.00% 2 Missing :warning:
editoast/src/views/infra/errors.rs 75.00% 2 Missing :warning:
editoast/src/views/infra/lines.rs 77.77% 2 Missing :warning:
editoast/src/views/infra/objects.rs 77.77% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #8361 +/- ## ============================================ + Coverage 37.94% 38.43% +0.48% Complexity 2163 2163 ============================================ Files 1248 1242 -6 Lines 114950 113713 -1237 Branches 3135 3131 -4 ============================================ + Hits 43623 43705 +82 + Misses 69479 68164 -1315 + Partials 1848 1844 -4 ``` | [Flag](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `75.59% <ø> (ø)` | | | [editoast](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `66.81% <56.89%> (+<0.01%)` | :arrow_up: | | [front](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `16.69% <ø> (+0.34%)` | :arrow_up: | | [gateway](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `2.03% <ø> (ø)` | | | [railjson_generator](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `87.49% <ø> (ø)` | | | [tests](https://app.codecov.io/gh/OpenRailAssociation/osrd/pull/8361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `72.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SharglutDev commented 1 month ago

Maybe a rebase issue for all the front files in this PR ?