OpenRarity / open-rarity

Reference implementation of the OpenRarity protocol with Python.
Apache License 2.0
218 stars 47 forks source link

OpenRarity rank not calculating correctly on Skulptuur collection #114

Closed tyoffice closed 1 year ago

tyoffice commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

Information OpenRarity incorrectly calculating rarity.

To Reproduce Steps to reproduce the behavior: Compare rarity rank betweek sites. Look at traits in collection. Camera heigh = high is the second rarest trait and rank should reflect that.

Expected behavior Recalculate rarity on this collection to accurately reflect traits.

Screenshots If applicable, add screenshots to help explain your problem.

Environment

Additional context Add any other context about the problem here.

impreso commented 1 year ago

Hi thanks for reporting. This is not a bug and OR works as expected. I checked the collection and Camera Height = High is not a unique trait. Here are all assets with this trait: https://opensea.io/collection/skulptuur-by-piter-pasma?search[sortAscending]=true&search[sortBy]=UNIT_PRICE&search[stringTraits][0][name]=camera_height&search[stringTraits][0][values][0]=high

We consider whole trait combination when we compute rarity not a single trait and this particular asset has much less rare traits in the combination.

tyoffice commented 1 year ago

Do you notice the rarity rank for all other assets with that trait? They are ranked 21-80. This is the only asset with that trait outside of that range and it's ranked 975. It also has a rare environment trait, which is why it should be among the rarest of that group.