search

OpenRealEstate / OpenRealEstate.NET

OBSOLETE REPO - PLEASE DO NOT USE. Use https://github.com/OpenRealEstate instead
MIT License
10 stars 10 forks source link

Changed agencies to offices #49

Closed jsaunders909 closed 6 years ago

jsaunders909 commented 6 years ago

Hopefully Ive done everything OK this is my first attempt at any contributions

PureKrome commented 6 years ago

Hi @jsaunders909 - thanks heaps for looking into this repo and code :) really appreciate it

I've been away for 2 weeks on holidays (read: offline for most of this time for some rest) which is why I've been slow to reply.

Now, this repo is an old repo that is not going to be getting any more love any more. In effect, all the code in this repo is now obsolete.

I've moved all of the code into newer repo's: https://github.com/OpenRealEstate

Everything has been split up into nicer parts.

In the new repo's, I've also removed any reference to Offices (previously known as Agencies) and Agents (stand alone, vs an Agent(s) assigned to a Listing).

As such, I'm going to close this PR and amend the README file (with info about how this repo is closed) to better communicate the repo's status/intentions.

If you are currently using OpenRealEstate in some project, please don't hesitate to use the new nuget packages and libraries, found in the other repo's.

As to some feedback regarding the PR itself :) A quick fly-through review seemed to make it look ok, except on some variable name changes like this one or like this one. My guess is that you did a blanket copy/paste replacement :)