search

OpenRefine / openrefine.org

Source website for openrefine.org
https://openrefine.org
Other
133 stars 119 forks source link

For the issue #263 - Add back a top level docs/technical-reference/architecture page to prevent broken links #272

Closed aakash-a-dev closed 8 months ago

aakash-a-dev commented 8 months ago

Fix for #263

Where on redirecting docs/technical-reference/architecture before this was giving 404 error but now it's gives following output image This changes made on the best of my understanding I will appreciate if there is any feedback on which I can work on to make it better.

netlify[bot] commented 8 months ago

Deploy Preview for openrefine-website ready!

Name Link
Latest commit fd89d91a8c5e9216dd818d0272ecb093f5ca0fe3
Latest deploy log https://app.netlify.com/sites/openrefine-website/deploys/659c60f533ff9c0008109ca8
Deploy Preview https://deploy-preview-272--openrefine-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

magdmartin commented 8 months ago

@aakash-a-dev thanks for the PR. The page looks good to me. Please note that you need to make the reference to the original issue in the PR description (and not the title) for Github to create the link automatically. I already edited your initial comment to reflect that change.

@ostephens is the new page located where you expected to address the 404?

aakash-a-dev commented 8 months ago

@magdmartin Thank you, now onwards I will take care of this in mind. I am looking forward to see this as Merge and ready to work on the feedback if there any.

wetneb commented 8 months ago

Thanks for working on this! I think we could as well just solve this by adding an actual redirect (not a new page) to either versions. Redirects can be defined by editing the static/_redirects page, which follows the syntax used by Netlify. https://github.com/OpenRefine/openrefine.org/blob/master/static/_redirects https://docs.netlify.com/routing/redirects/

If you want to make this a page then I would simply call that "Architecture" (no need to call it a redirect, since it isn't one) and point to both versions in a more concise way.

aakash-a-dev commented 8 months ago

@wetneb I did the redirection and tested on Netlify manually it didn't worked so I update the architecture page. If in case we have to do the redirection may be I require a little more direction. But I tried everything mentioned in the documentation.

aakash-a-dev commented 8 months ago

Hello @magdmartin and @ostephens I didn't heard on my this PR.