OpenRefine / openrefine.org

Source website for openrefine.org
https://openrefine.org
Other
133 stars 119 forks source link

Upload Offline pdf docs #304

Closed monstajoe2002 closed 2 months ago

netlify[bot] commented 7 months ago

Deploy Preview for openrefine-website ready!

Name Link
Latest commit 6bf109932c1ab026c5e3ec1a319afe9296dc088f
Latest deploy log https://app.netlify.com/sites/openrefine-website/deploys/65e8931e184444000804d290
Deploy Preview https://deploy-preview-304--openrefine-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wetneb commented 3 months ago

Apologies in the delay for reviewing this. I don't think uploading a static PDF in this repository is a good move as it will get outdated as docs are edited.

ostephens commented 3 months ago

Perhaps implementing a PDF generator that works with docusaurus like https://github.com/jean-humann/docs-to-pdf might be an option?

monstajoe2002 commented 3 months ago

I tried that, it's no different than the other plugin. Also, it didn't work on my machine.

ostephens commented 3 months ago

Sorry both - I've deleted my last comment as I think it was totally wrong

ostephens commented 3 months ago

@monstajoe2002 I agree with @wetneb uploading a static file is not a good solution here. I feel there must be a better solution - what were the issues you saw with docs-to-pdf and prince?

ostephens commented 3 months ago

@monstajoe2002 I'd really like to support achieving your goal here, but I wonder if you could:

magdmartin commented 2 months ago

@ostephens I agree with your point. Let's keep the requirement in #275 @monstajoe2002 I am closing this PR as we refine the requirement first.