martinsumner
commented
1 year ago The test was passing due to good fortune in timing. There is a fundamental issue with this PR.
When the node comes back up, the primaries will be reinstated and the reaps will occur. However, handoffs may not have occurred. So the reaps can complete, the clusters can appear to be in-sync ... but once handoffs complete the tombstones re-appear and full-sync must still resolve the issue.
There is no obvious was of deferring reaps until after handoffs, so there is no way forward for this solution.
Rather than wait for the next read (which may never happen) to repair - try and defer, as the reaper will not process until the failure has cleared.
https://github.com/nhs-riak/riak_test/pull/1
https://github.com/basho/riak_kv/issues/1869