Pass dialyzer for riak_test

[martinsumner]

Depends on updates to the riak erlang clients, most issues with dialyzer were related to types not being correctly or completely defined within these clients.

Most of the remaining changes are related to removing dead/unused code paths, or converting assertions that can never fail (according to types) to explicit pattern matches.

In some cases there is hidden magic within clients that allow incorrect types to work, and be tested. For example with using string or binary as content type for PUT, the test has been changed to reflect the advertised type.

Some deprecated stuff has been removed, rather than having the effort of fixing it:

• mapred_search_switch (yokozuna no longer supported), test was not in any group;
• rpc_output (a test of lager?) not in any group;
• replication2_pg long since marked as deprecated, and doesn't currently work (although the test may not have been replaced with a working case). the proxy-get feature it tests is part of CS and not KV.

To run dialyzer in OTP 26 uncomment the no_unknown warning in rebar.config for check profile. As riak_test does not explicitly load riak, then any internal riak functions referred to in a test will be unknown.

There are two cases of explicitly allowing dialyzer errors:

• in job_nenable_common where the fix to a dialyzer error is not permitted according to a comment
• in verify_api_timeout where there is a need to test an illegitimate client request

[martinsumner]

Now updated to make the otp version specific rebar.config changes via rebar.config.script - so no edits required to run ./rebar3 as check do dialyzer on both OTP24 and OTP26.

Should now be clean for both OTP versions.

[tburghart]

Regarding tests/job_enable_common.erl:

This is very old code, and I wouldn't take my 8-year-old comments as gospel today ;)

The only functional difference I see if that rt:httpc/1 invokes rt:wait_for_service(Node, riak_kv) along the way, so whatever I ran into may have been a timing issue that would be better handled further up the stack.

My inclination would be to remove the -dialyzer exclusion, change the code to that which doesn't require it, and add a comment that there could be a potential timing issue that should be handled in Node setup ... which may not even be relevant given that all of the rt:deploy_nodes(...) code has itself been thoroughly reworked.

This also eliminates the need for inclusion of rhc/include/rhc.hrl.

Possible (entirely untested) replacement:

make_url(Node, Parts) ->
    make_url(Node, http, Parts).

%% @hidden
%% Previous implementations of this function noted reliability issues that
%% may have been due to timing and could benefit from assuring that
%%  `rt:wait_for_service(Node, riak_kv)'
%% is invoked before this function.
make_url(Node, http = Scheme, Parts) ->
    {ok, {IP, Port}} = rt:get_http_conn_info(Node),
    make_url(Scheme, IP, Port, Parts);
make_url(Node, https = Scheme, Parts) ->
    {ok, {IP, Port}} = rt:get_https_conn_info(Node),
    make_url(Scheme, IP, Port, Parts).

make_url(Scheme, Host, Port, Parts) ->
    lists:flatten([io_lib:format("~s://~s:~b", [Scheme, Host, Port]), Parts]).

[tburghart]

My results:

# git status
On branch nhse-d34-wdaymerge-dialyzer
Your branch is up to date with 'origin/nhse-d34-wdaymerge-dialyzer'.
# rebar3 --version
rebar 3.22.1 on Erlang/OTP 24 Erts 12.3.2.17
# ls -l riak
... riak -> ../../wday/riak-3.2/riak
# rebar3 as check dialyzer
Warnings written to _build/check/24.3.4.17.dialyzer_warnings
Warnings occurred running dialyzer: 43

Caveats:

• riak is pointed to our current Riak 3.2 build, which is known to differ from yours, because I was unable to build yours (nhse-develop-3.4) due to its reliance on wget.
• I commented out the riak_kv and riak_repl dependencies in the check profile for the same reason, but they shouldn't be needed anyway if the riak symlink points to a proper build.

Results file attached.

24.3.4.17.dialyzer_warnings

[tburghart]

I was able to hack together a build of Riak from the nhse-develop-3.4 branch using our eleveldb build but still commenting out the riak_kv and riak_repl deps in the check profile. This gets me down to 37 warnings: 24.3.4.17.dialyzer_warnings

[martinsumner]

I think all dialyzer warnings should now be resolved