OpenRoberta / openroberta-lab

The programming environment »Open Roberta Lab« by Fraunhofer IAIS enables children and adolescents to program robots. A variety of different programming blocks are provided to program motors and sensors of the robot. Open Roberta Lab uses an approach of graphical programming so that beginners can seamlessly start coding. As a cloud-based application, the platform can be used without prior installation of specific software but runs in any popular browser, independent of operating system and device.
Apache License 2.0
127 stars 122 forks source link

Move Python visitWaitStmt to AbstractPythonVisitor #1611

Open NiHoffmann opened 10 months ago

NiHoffmann commented 10 months ago

Idea: Move Python visitWaitStmt to AbstractPythonVisitor

Background: Mbot2, Edison(here we have an unneeded pass at the end),MicroBit, Spike have the same visitWaitStmt function ev3,nao,robotino also have the same function but add a timeout for a couple of mili-sec

Solution: move visitWaitStmt to AbstractPythonVisitor, add Abstract method called e.g. "waitStatementTimeout" to AbstractPythonVisitor where all systems can add their own implementation of wait

make sure to remove unnecessary pass at the end of edisons function, since wait until block can/should not be left empty