SenseBox: Sound sensor returns wrong value

OpenRoberta / openroberta-lab

The programming environment »Open Roberta Lab« by Fraunhofer IAIS enables children and adolescents to program robots. A variety of different programming blocks are provided to program motors and sensors of the robot. Open Roberta Lab uses an approach of graphical programming so that beginners can seamlessly start coding. As a cloud-based application, the platform can be used without prior installation of specific software but runs in any popular browser, independent of operating system and device.

Apache License 2.0

125 stars 121 forks source link

SenseBox: Sound sensor returns wrong value #334

Closed bjost2s closed 4 years ago

bjost2s commented 4 years ago

Describe the bug Sound sensor returns simple analog read instead of the sound loudness.

To Reproduce Create a program as in the screenshot and open the source code view

Expected behavior Sensor returns the maximum absolute value from one wave period converted to % (0-100)

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context see implementation for the sound sensor for Calliope

bjost2s commented 4 years ago

The provided solution is not sufficient:

In general we have decided not to add any more code to NEPODefs.h, desired place for new functions is inline, see #278
The calculation of max in the function reduces the range from the output, 0 (no noise) can never be reached. -> We want to calculate the peak amplitude and convert it in percent, see e.g. here, please improve the function, remove it from NEPODefs.h and create it like in #278 proposed

VinArt commented 4 years ago

Moving to helper methods is currently impossible since helper methods for C based robots are not yet implemented

boonto commented 4 years ago

Seems to work fine, constant noise, as well as short loud claps are detected.