search

OpenRoberta / robertalab-ev3dev

roberta lab connector for ev3dev
Apache License 2.0
17 stars 14 forks source link

OpenRoberta/robertalab#722 & OpenRoberta/robertalab#694 mappings #54

Closed boonto closed 6 years ago

boonto commented 6 years ago

OpenRoberta/robertalab#722 added parameter mapping OpenRoberta/robertalab#694 changed output range

ensonic commented 6 years ago

Thanks & Looks good. Please fix the style warnings (see the travis build).

codecov-io commented 6 years ago

Codecov Report

Merging #54 into develop will increase coverage by 1.34%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
+ Coverage    61.69%   63.04%   +1.34%     
===========================================
  Files            7        7              
  Lines         1308     1315       +7     
===========================================
+ Hits           807      829      +22     
+ Misses         501      486      -15
Impacted Files Coverage Δ
roberta/ev3.py 40.48% <50%> (+2.82%) :arrow_up:
roberta/lab.py 51.74% <0%> (-0.34%) :arrow_down:
roberta/test_BlocklyMethods.py 99.01% <0%> (ø) :arrow_up:
roberta/test_ev3.py 100% <0%> (ø) :arrow_up:
roberta/test.py 100% <0%> (ø) :arrow_up:
roberta/test_lab.py 95.49% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5438f8b...0f7280a. Read the comment docs.

boonto commented 6 years ago

@ensonic the style warnings are fixed now.