search

OpenRowingCommunity / c2logbook

A Dart wrapper around the Concept2 Logbook API
GNU Lesser General Public License v3.0
1 stars 1 forks source link

Find a dart compatible oauth library #4

Open MoralCode opened 7 months ago

MoralCode commented 7 months ago

turns out https://pub.dev/packages/oauth2_client uses the flutter SDK not strictly dart.

this is breaking CI

MoralCode commented 7 months ago

another option includes simply reclassifying this as a Flutter library. which may or may not be a good choice

MoralCode commented 7 months ago

For the webhook usecase, tokens probably dont need to be persisted once the hook is set up as the data will simply arrive.

For other usecases we may need to find a way for the consumer of this library to be responsible for persistence

MoralCode commented 7 months ago

Having a library boundary between the code that persists tokens to secure storage and the code that uses those tokens seems to be a programming/design pattern I haven't seen before. More research may be needed on how best to do this

MoralCode commented 7 months ago

tbh im sorta leaning towards https://pub.dev/packages/oauth2 since it looks like its made by dart themselves

MoralCode commented 7 months ago

hmmm that library may not be great... https://github.com/dart-lang/tools/issues/349

will experiment and see how it goes

MoralCode commented 6 months ago

this library has been found and imported, it just needs to be integrated