OpenSAGE / OpenSAGE.BlenderPlugin

A Westwood 3D Blender plugin. Imports & exports the W3D/W3X format to/from Blender.
https://opensage.github.io
GNU Lesser General Public License v3.0
50 stars 18 forks source link

Zh export issues #142

Closed Tarcontar closed 4 years ago

feliwir commented 4 years ago

from now on only bones should be animated, test if changing their visibility also hides associated meshes. Also what should we do on export if a user has animated a mesh instead of its bone?

So there are multiple things we need to consider:

Maybe we should get some user opinions

codecov[bot] commented 4 years ago

Codecov Report

Merging #142 into master will increase coverage by 0.06%. The diff coverage is 99.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   97.95%   98.01%   +0.06%     
==========================================
  Files          49       49              
  Lines        4099     4075      -24     
  Branches      757      740      -17     
==========================================
- Hits         4015     3994      -21     
+ Misses         37       36       -1     
+ Partials       47       45       -2     
Impacted Files Coverage Δ
io_mesh_w3d/custom_properties.py 100.00% <ø> (ø)
io_mesh_w3d/common/utils/mesh_export.py 90.80% <96.15%> (+0.38%) :arrow_up:
io_mesh_w3d/common/structs/animation.py 96.29% <100.00%> (ø)
io_mesh_w3d/common/structs/hierarchy.py 96.69% <100.00%> (-0.03%) :arrow_down:
io_mesh_w3d/common/structs/hlod.py 97.22% <100.00%> (ø)
io_mesh_w3d/common/structs/mesh.py 95.79% <100.00%> (-0.03%) :arrow_down:
io_mesh_w3d/common/utils/animation_export.py 96.59% <100.00%> (ø)
io_mesh_w3d/common/utils/animation_import.py 97.33% <100.00%> (-1.41%) :arrow_down:
io_mesh_w3d/common/utils/box_import.py 100.00% <100.00%> (+6.45%) :arrow_up:
io_mesh_w3d/common/utils/helpers.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86e08f6...6af0cc1. Read the comment docs.