search

OpenSC / OpenSC.tokend

Tokend module for OS X with support for all cards supported by OpenSC
Other
36 stars 20 forks source link

Fixes build and installation on OS X 10.11 #18

Closed frankmorgner closed 8 years ago

frankmorgner commented 9 years ago

@martinpaljak any objections merging this PR?

frankmorgner commented 9 years ago

I implemented pinStatus(). However, I'm not sure if it will have any impact. During my tests this function was never called by the upper layer anyway...

martinpaljak commented 8 years ago

I'll have a look at all the OSX code in the light of 10.11 (read: boot the still not-default parition and try compiling-using everything) before the end of this week.

The pin status IIRC was never really obvious and last time I checked, had no relation other than "ui sugar" for some situations that had a single global PIN (thus a possible global "unlocked" state)

metsma commented 8 years ago

Why not keep the support older OSX versions? -mmacosx-version-min=10.9 forces to min osx version

martinpaljak commented 8 years ago

SDK and minimal OSX version must not be in sync

metsma commented 8 years ago

SDKROOT = macosx; This points to latest SDK

frankmorgner commented 8 years ago

I hope to get additional confirmation about the PIN issue from @mouse07410

frankmorgner commented 8 years ago

Apple's support for 10.8 will soon drop, see http://www.computerworld.com/article/2950580/operating-systems/the-end-is-near-for-os-x-mountain-lion-support.html. 10.9 differs significantly in its PC/SC layer, there is no reason to officially support older versions.

You may compile with different flags yourself and it will still work on older versions...

frankmorgner commented 8 years ago

got confirmation from @mouse07410 in https://github.com/OpenSC/OpenSC/issues/570

metsma commented 8 years ago

"10.9 differs significantly in its PC/SC layer" compared with 10.10 or ...?

frankmorgner commented 8 years ago

@metsma yes, with 10.10 apple decided to implement its own PC/SC framework with all the fun of a number of new bugs...

frankmorgner commented 8 years ago

see http://ludovicrousseau.blogspot.de/2015/10/os-x-el-capitan-and-smart-cards-status.html

metsma commented 8 years ago

I know this info but don't understand what you mean with "10.9 differs significantly in its PC/SC layer, there is no reason to officially support older versions." 10.9 pcsc layer is same as 10.8 and 10.7. Or you want rule out also 10.9?

frankmorgner commented 8 years ago

See https://github.com/OpenSC/OpenSC/issues/480 and https://github.com/OpenSC/OpenSC/pull/516

metsma commented 8 years ago

then you should change the minimum to 10.10 then???

frankmorgner commented 8 years ago

Well... it is set so for the OpenSC bundle. Why the tokend needs 10.9, I don't know. This restriction has already been there earlier.

mouse07410 commented 8 years ago

I don't think OpenSC.tokend still needs 10.9.

When can we hope to see this pull merged?

frankmorgner commented 8 years ago

@martinpaljak do you have any updates yet?

@martinpaljak by the way, what was the reason to include all the system headers in OpenSC.tokend? Apple's smartcardservices don't need to ship them...

frankmorgner commented 8 years ago

@martinpaljak want to add me as contributor so that I can merge/handle the tokend part, too?

frankmorgner commented 8 years ago

@martinpaljak ... with write access, please ;-)

LudovicRousseau commented 8 years ago

@frankmorgner you now have write access. https://github.com/OpenSC/OpenSC.tokend/settings/collaboration

frankmorgner commented 8 years ago

thanks