Changes to properly identify IDPrime MD 840

OpenSC / OpenSC

Open source smart card tools and middleware. PKCS#11/MiniDriver/Tokend

https://github.com/OpenSC/OpenSC/wiki

GNU Lesser General Public License v2.1

2.47k stars 711 forks source link

Closed msetina closed 1 month ago

msetina commented 1 month ago

Previously MD 840 was identified as 940. Also changed the part where mechanism are assigned to the card, so that EC is also added as by spec.

Fixes #3106

Jakuje commented 1 month ago

Thank you for the PR. I will run some tests on the cards I have tomorrow.

msetina commented 1 month ago

Did you change code style lately? I followed the file.... It wants different indents.

Jakuje commented 1 month ago

No, the clang-format does not capture all the corner cases. Feel free to ignore the proposa of changes to the array of structs.

The long condition should be wrapped but the line needs to end with the logical operator, not start with it and the continuation should be 2 tabs.