search

OpenSC / pkcs11-helper

Library that simplifies the interaction with PKCS#11 providers for end-user applications using a simple API and optional OpenSSL engine
Other
66 stars 43 forks source link

Respect login required and always authenticate #45

Closed alonbl closed 2 years ago

alonbl commented 3 years ago

Hi @manonfgoo, Can you please have a look? Thanks,

manonfgoo commented 3 years ago

Dear Alon,

wich version of Automake / Autoconf is required ?

I get the following errors:

@.*** pkcs11-helper % autoconf -V

autoconf (GNU Autoconf) 2.71

Copyright (C) 2021 Free Software Foundation, Inc.

License GPLv3+/Autoconf: GNU GPL version 3 or later

https://gnu.org/licenses/gpl.html, https://gnu.org/licenses/exceptions.html

This is free software: you are free to change and redistribute it.

There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.

@.*** pkcs11-helper % autoconf

@.*** pkcs11-helper % autoconf

configure.ac:406: warning: The preprocessor macro `STDC_HEADERS' is obsolete.

configure.ac:406: Except in unusual embedded environments, you can safely include all

configure.ac:406: ISO C90 headers unconditionally.

configure.ac:423: warning: Update your code to rely only on HAVE_SYS_TIME_H,

configure.ac:423: then remove this warning and the obsolete code below it.

configure.ac:423: All current systems provide time.h; it need not be checked for.

configure.ac:423: Not all systems provide sys/time.h, but those that do, all allow

configure.ac:423: you to include it and time.h simultaneously.

@.*** pkcs11-helper % ./configure

configure: error: cannot find required auxiliary files: install-sh config.guess config.sub

@.*** pkcs11-helper %

Kind regrds, Manon

Von: Alon Bar-Lev @.> Antworten an: OpenSC/pkcs11-helper @.> Datum: Freitag, 1. Oktober 2021 um 21:29 An: OpenSC/pkcs11-helper @.> Cc: Manon Goo @.>, Mention @.***> Betreff: Re: [OpenSC/pkcs11-helper] Respect login required and always authenticate (#45)

Hi @manonfgoohttps://github.com/manonfgoo, Can you please have a look? Thanks,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/OpenSC/pkcs11-helper/pull/45#issuecomment-932496715, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABTP25FYYAR5PPXUJI4FICLUEYD3LANCNFSM5E36MLTQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

alonbl commented 3 years ago

Please run autoreconf -ivf instead of what you are running.

manonfgoo commented 3 years ago

Looks good,

Works and is able to sign without setting "pin_cache_ignore_user_consent" on opensc.conf

Kind regards, Manon

Von: Alon Bar-Lev @.> Antworten an: OpenSC/pkcs11-helper @.> Datum: Samstag, 2. Oktober 2021 um 05:40 An: OpenSC/pkcs11-helper @.> Cc: Manon Goo @.>, Mention @.***> Betreff: Re: [OpenSC/pkcs11-helper] Respect login required and always authenticate (#45)

Please run autoreconf -ivf instead of what you are running.

— You are receiving this because you were mentioned. Reply to this email directly, https://github.com/OpenSC/pkcs11-helper/pull/45#issuecomment-932674788, or https://github.com/notifications/unsubscribe-auth/ABTP25AMJ7QAUSTOYDPTMBTUEZ5KDANCNFSM5E36MLTQ. Triage notifications on the go with GitHub Mobile for https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign=notification-email&utm_medium=email&utm_source=github.

manonfgoo commented 3 years ago

Dear Alon,

Sorry, I tested against the wrong pkcs11 module (/usr/local/lib/libykcs11.dylib). With when using pkcs11-helper as a Frontend to OpenSC setting "pin_cache_ignore_user_consent" in opensc.conf is nececary to get signing done from gnupg-pkcs11-scd. Is this the outcome you would expect? This because without your patch It would not work at all or would you expect all of the functionality without setting "pin_cache_ignore_user_consent" in opensc.conf to be available.

Kind regards, Manon

Am 06.10.21, 00:13 schrieb "Manon Goo" @.***>:

Looks good, 

Works and is able to sign without setting "pin_cache_ignore_user_consent" on opensc.conf

Kind regards,
Manon

Von: Alon Bar-Lev ***@***.***>
Antworten an: OpenSC/pkcs11-helper ***@***.***>
Datum: Samstag, 2. Oktober 2021 um 05:40
An: OpenSC/pkcs11-helper ***@***.***>
Cc: Manon Goo ***@***.***>, Mention ***@***.***>
Betreff: Re: [OpenSC/pkcs11-helper] Respect login required and always authenticate (#45)

Please run autoreconf -ivf instead of what you are running.

—
You are receiving this because you were mentioned.
Reply to this email directly, https://github.com/OpenSC/pkcs11-helper/pull/45#issuecomment-932674788, or https://github.com/notifications/unsubscribe-auth/ABTP25AMJ7QAUSTOYDPTMBTUEZ5KDANCNFSM5E36MLTQ.
Triage notifications on the go with GitHub Mobile for https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign=notification-email&utm_medium=email&utm_source=github.
alonbl commented 3 years ago

With native yk it is working, but with opensc it is not? Can you please provide debug logs?

alonbl commented 3 years ago

Hi, Please send me logs so I can look into it. Thanks!