search

OpenSC / pkcs11-helper

Library that simplifies the interaction with PKCS#11 providers for end-user applications using a simple API and optional OpenSSL engine
Other
65 stars 43 forks source link

Fixed autoconf warnings reported in #42 #46

Closed kloczek closed 2 years ago

kloczek commented 3 years ago

Mostly missing [] qotes amd other things autogenerated by wutoupdate. Those fixes do not break using older autoconf.

alonbl commented 3 years ago

Thanks! I believe most is not required or create a dependency with newer tools Can you please explain why each change is required?

kloczek commented 3 years ago
alonbl commented 3 years ago 
* building using autoconf older than 2.69 does not make any sense (that version IIRC is 9y old and anything older contains even more bugs)

There is a difference between which version you are using and which is the minimum.

* remove leading space before tab (just cleanup)

That's ok.

* LT_INIT is available since +8 years so checking is that macro available does not make to much sense (simplification)

Older distributions have older libtool, I do not want to remove older libtool support unless mandatory.

* everything else have been generated by autoupdate. After using that command I've removed only [obsoleted] warnings + some explanation what needs to be done on making some manual decisions about how to resolve [obsoleted] parts.

We can entirely remove the time handle as we do not check for it. Leaving the AC_HEADER_STDC for now.

kloczek commented 3 years ago

Which one older versions of libtools you wnat to support? https://git.savannah.gnu.org/cgit/libtool.git/refs/tags Please try to find one distribution of any OS which do not support laster libtool.

alonbl commented 3 years ago

Which one older versions of libtools you wnat to support?

libtool-1.5, current distributions supports libtool-2.2, however older rhel do not and I do not want to break it unless there is a very good reason.

alonbl commented 2 years ago

Closing this for now