Fix mutex locking in _pkcs11h_threading_cond{Init,Wait} functions.

OpenSC / pkcs11-helper

Library that simplifies the interaction with PKCS#11 providers for end-user applications using a simple API and optional OpenSSL engine

Other

66 stars 43 forks source link

Fix mutex locking in _pkcs11h_threading_cond{Init,Wait} functions. #65

Closed arrowd closed 9 months ago

arrowd commented 10 months ago

According to pthread_cond_wait manpage, the mutex has to be locked by the same thread that is going to call pthread_cond_wait afterwards. This was not true before this change and was causing test-slotevent to busy-loop on FreeBSD.

alonbl commented 10 months ago

Hi, I modified a bit this patch and saw Sponsored by: Serenity Cybersecurity, LLC comment in commit message, this is not something that I can apply. Please use the standard sign-off-by statement.

arrowd commented 10 months ago

Let's just remove the "Sponsored by" tag, then.

alonbl commented 10 months ago

please sign-off so we have no future issues, trivial issues I accept without.

alonbl commented 9 months ago

Thank you, merged with some minor changes.