OpenSCAP / openscap-daemon

Manages continuous scans of your infrastructure
https://www.open-scap.org/tools/openscap-daemon
GNU Lesser General Public License v2.1
106 stars 32 forks source link

Issue #102: Add a generator of updated Dockerfiles #106

Closed jan-cerny closed 7 years ago

jan-cerny commented 7 years ago

I would like to introduce a Dockerfile and other files needed to build a container image that is used as worker for atomic scan. It mostly mirrors files used to build registry.access.redhat.com/openscap. Main difference is that this is based on Fedora and OpenSCAP daemon is from current sources, not from RPM package.

This PR could be beneficial for development purposes, because we will easily test OpenSCAP Daemon integration with Atomic.

I also remove the old outdated SPC Dockerfiles in atomic and atomic-diff directories.

mpreisler commented 7 years ago

@jan-cerny could we add it to a directory? install.sh in the git root is very confusing. openscap-daemon can be used outside of atomic scan.

jan-cerny commented 7 years ago

I have moved everything into a new directory.

The actual Dockerfile is now generated by script ./generate-dockerfile.py. That's because the users can generate Dockerfiles that use either distribution packages or download the latest upstream from git and build the software from source.

The default choice is packages. You can add these options to ./generate-dockerfile.py to generate modified Dockerfile: --openscap-from-git, --ssg-from-git, --daemon-from-git

jan-cerny commented 7 years ago

Ready for review.

jan-cerny commented 7 years ago

Hmmmm, I would need to build from local sources as well, but I can't find a way how to do it if the Dockerfile is in a subdirectory and not in the root directory

mpreisler commented 7 years ago

@jan-cerny we need other people to also review PRs, please ask the wider team to review

mpreisler commented 7 years ago

@jan-cerny Do we need other sources for openscap-daemon than the local working copy? You can do anything with just the local working copy, get any tag, branch, ... IMO we can drop the git clone for openscap-daemon. Agreed?

jan-cerny commented 7 years ago

@mpreisler Yes, I'll drop that, thank you.

jan-cerny commented 7 years ago

@mpreisler I have dropped that.

yuumasato commented 7 years ago

Ack.