Closed jan-cerny closed 7 years ago
@jan-cerny could we add it to a directory? install.sh in the git root is very confusing. openscap-daemon can be used outside of atomic scan
.
I have moved everything into a new directory.
The actual Dockerfile is now generated by script ./generate-dockerfile.py
. That's because the users can generate Dockerfiles that use either distribution packages or download the latest upstream from git and build the software from source.
The default choice is packages. You can add these options to ./generate-dockerfile.py
to generate modified Dockerfile: --openscap-from-git
, --ssg-from-git
, --daemon-from-git
Ready for review.
Hmmmm, I would need to build from local sources as well, but I can't find a way how to do it if the Dockerfile is in a subdirectory and not in the root directory
@jan-cerny we need other people to also review PRs, please ask the wider team to review
@jan-cerny Do we need other sources for openscap-daemon than the local working copy? You can do anything with just the local working copy, get any tag, branch, ... IMO we can drop the git clone for openscap-daemon. Agreed?
@mpreisler Yes, I'll drop that, thank you.
@mpreisler I have dropped that.
Ack.
I would like to introduce a Dockerfile and other files needed to build a container image that is used as worker for
atomic scan
. It mostly mirrors files used to buildregistry.access.redhat.com/openscap
. Main difference is that this is based on Fedora and OpenSCAP daemon is from current sources, not from RPM package.This PR could be beneficial for development purposes, because we will easily test OpenSCAP Daemon integration with Atomic.
I also remove the old outdated SPC Dockerfiles in
atomic
andatomic-diff
directories.