search

OpenSCAP / openscap-daemon

Manages continuous scans of your infrastructure
https://www.open-scap.org/tools/openscap-daemon
GNU Lesser General Public License v2.1
106 stars 32 forks source link

generate-dockerfile.py: updated to use builds from Koji #109

Closed matusmarhefka closed 6 years ago

matusmarhefka commented 6 years ago
openscap-ci commented 6 years ago

Can one of the admins verify this patch?

pep8speaks commented 6 years ago

Hello @matusmarhefka! Thanks for updating the PR.

Line 10:80: E501 line too long (118 > 79 characters) Line 11:80: E501 line too long (222 > 79 characters) Line 13:80: E501 line too long (229 > 79 characters) Line 15:80: E501 line too long (86 > 79 characters) Line 36:13: E203 whitespace before ':' Line 37:11: E203 whitespace before ':' Line 45:80: E501 line too long (84 > 79 characters) Line 73:80: E501 line too long (88 > 79 characters) Line 78:13: E128 continuation line under-indented for visual indent Line 80:9: E128 continuation line under-indented for visual indent Line 82:9: E128 continuation line under-indented for visual indent Line 84:9: E128 continuation line under-indented for visual indent Line 84:80: E501 line too long (81 > 79 characters) Line 85:80: E501 line too long (80 > 79 characters) Line 86:9: E128 continuation line under-indented for visual indent Line 87:80: E501 line too long (88 > 79 characters) Line 88:9: E128 continuation line under-indented for visual indent Line 90:9: E128 continuation line under-indented for visual indent Line 92:61: E711 comparison to None should be 'if cond is not None:' Line 93:9: E125 continuation line with same indent as next logical line Line 93:9: E128 continuation line under-indented for visual indent Line 102:80: E501 line too long (82 > 79 characters) Line 103:80: E501 line too long (82 > 79 characters) Line 128:34: E711 comparison to None should be 'if cond is not None:' Line 132:80: E501 line too long (80 > 79 characters) Line 133:80: E501 line too long (80 > 79 characters) Line 134:80: E501 line too long (140 > 79 characters) Line 146:29: E711 comparison to None should be 'if cond is not None:' Line 151:80: E501 line too long (84 > 79 characters) Line 162:26: E231 missing whitespace after ',' Line 163:32: E711 comparison to None should be 'if cond is not None:' Line 184:80: E501 line too long (106 > 79 characters) Line 187:80: E501 line too long (90 > 79 characters) Line 191:80: E501 line too long (88 > 79 characters) Line 209:80: E501 line too long (90 > 79 characters) Line 215:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated on August 31, 2017 at 11:12 Hours UTC
mpreisler commented 6 years ago

@openscap-ci add to whitelist

jan-cerny commented 6 years ago

Maybe we can also check if the base image is Fedora. It doesn't make sense to install packages from Koji on other operating systems.

mpreisler commented 6 years ago

I also wish this was done in multiple commits. The package manager cache clean is a completely separate change.

matusmarhefka commented 6 years ago

Commit 3fce706 should reflect all the provided feedback. Than you.

jan-cerny commented 6 years ago

Looks OK. I've tested this and it generates every Dockerfile as expected. Thank you!