Move atomic harden from atomic to OpenSCAP Daemon

[jan-cerny]

In this pull request we introduce the code that should be introduced into project Atomic to support Atomic hardening feature. We split off the code to a separate script that will be installed on host to /etc/atomic.d/scripts. The script will be shipped in "openscap" image.

[pep8speaks]

Hello @jan-cerny! Thanks for updating the PR.

• In the file container/remediate.py, following are the PEP8 issues :

Line 103:80: E501 line too long (80 > 79 characters)

• In the file generate-dockerfile.py, following are the PEP8 issues :

Line 10:80: E501 line too long (118 > 79 characters) Line 11:80: E501 line too long (222 > 79 characters) Line 13:80: E501 line too long (229 > 79 characters) Line 15:80: E501 line too long (86 > 79 characters) Line 37:13: E203 whitespace before ':' Line 38:11: E203 whitespace before ':' Line 46:80: E501 line too long (84 > 79 characters) Line 74:80: E501 line too long (88 > 79 characters) Line 79:13: E128 continuation line under-indented for visual indent Line 81:9: E128 continuation line under-indented for visual indent Line 83:9: E128 continuation line under-indented for visual indent Line 85:9: E128 continuation line under-indented for visual indent Line 85:80: E501 line too long (81 > 79 characters) Line 86:80: E501 line too long (80 > 79 characters) Line 87:9: E128 continuation line under-indented for visual indent Line 88:80: E501 line too long (88 > 79 characters) Line 89:9: E128 continuation line under-indented for visual indent Line 91:9: E128 continuation line under-indented for visual indent Line 93:61: E711 comparison to None should be 'if cond is not None:' Line 94:9: E125 continuation line with same indent as next logical line Line 94:9: E128 continuation line under-indented for visual indent Line 103:80: E501 line too long (82 > 79 characters) Line 104:80: E501 line too long (82 > 79 characters) Line 129:34: E711 comparison to None should be 'if cond is not None:' Line 133:80: E501 line too long (80 > 79 characters) Line 134:80: E501 line too long (80 > 79 characters) Line 135:80: E501 line too long (140 > 79 characters) Line 147:29: E711 comparison to None should be 'if cond is not None:' Line 152:80: E501 line too long (84 > 79 characters) Line 163:26: E231 missing whitespace after ',' Line 164:32: E711 comparison to None should be 'if cond is not None:' Line 185:80: E501 line too long (106 > 79 characters) Line 188:80: E501 line too long (90 > 79 characters) Line 192:80: E501 line too long (88 > 79 characters) Line 210:80: E501 line too long (90 > 79 characters) Line 216:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated on September 07, 2017 at 11:14 Hours UTC

[jan-cerny]

Jenkins has a big exception.

[jan-cerny]

I have removed 3b5ec76 from this PR to go back to original version.

[yuumasato]

The code looks good. But can the mixed use of terms like harden and remediate cause confusions? The changes on Atomic side don't mention harden, just remediate.

[mpreisler]

ACK