search

OpenSCAP / openscap-daemon

Manages continuous scans of your infrastructure
https://www.open-scap.org/tools/openscap-daemon
GNU Lesser General Public License v2.1
106 stars 32 forks source link

Support for atomic help feature #118

Closed matusmarhefka closed 6 years ago

matusmarhefka commented 6 years ago
pep8speaks commented 6 years ago

Hello @matusmarhefka! Thanks for updating the PR.

Line 10:80: E501 line too long (118 > 79 characters) Line 11:80: E501 line too long (222 > 79 characters) Line 13:80: E501 line too long (229 > 79 characters) Line 15:80: E501 line too long (92 > 79 characters) Line 17:80: E501 line too long (178 > 79 characters) Line 39:13: E203 whitespace before ':' Line 40:11: E203 whitespace before ':' Line 48:80: E501 line too long (84 > 79 characters) Line 76:80: E501 line too long (88 > 79 characters) Line 81:13: E128 continuation line under-indented for visual indent Line 83:9: E128 continuation line under-indented for visual indent Line 85:9: E128 continuation line under-indented for visual indent Line 87:9: E128 continuation line under-indented for visual indent Line 87:80: E501 line too long (81 > 79 characters) Line 88:80: E501 line too long (80 > 79 characters) Line 89:9: E128 continuation line under-indented for visual indent Line 90:80: E501 line too long (88 > 79 characters) Line 91:9: E128 continuation line under-indented for visual indent Line 93:9: E128 continuation line under-indented for visual indent Line 95:61: E711 comparison to None should be 'if cond is not None:' Line 96:9: E125 continuation line with same indent as next logical line Line 96:9: E128 continuation line under-indented for visual indent Line 105:80: E501 line too long (82 > 79 characters) Line 106:80: E501 line too long (82 > 79 characters) Line 131:34: E711 comparison to None should be 'if cond is not None:' Line 135:80: E501 line too long (80 > 79 characters) Line 136:80: E501 line too long (80 > 79 characters) Line 137:80: E501 line too long (140 > 79 characters) Line 149:29: E711 comparison to None should be 'if cond is not None:' Line 154:80: E501 line too long (84 > 79 characters) Line 165:26: E231 missing whitespace after ',' Line 166:32: E711 comparison to None should be 'if cond is not None:' Line 187:80: E501 line too long (106 > 79 characters) Line 190:80: E501 line too long (90 > 79 characters) Line 194:80: E501 line too long (88 > 79 characters) Line 212:80: E501 line too long (90 > 79 characters) Line 218:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated on November 07, 2017 at 16:35 Hours UTC
jan-cerny commented 6 years ago

@matusmarhefka Please fix the conflicts.

matusmarhefka commented 6 years ago

Commit f392eb8 removes printing information about bundled datastreams and profiles. container/help.sh now only prints image version, description and versions of OpenSCAP RPM packages bundled inside the image. Version and description is taken from the image labels so the container/help.sh script itself does not introduce any help text about the image.

matusmarhefka commented 6 years ago

@jan-cerny I think this can be merged. I reported a new issue on how to provide a user with info about datastreams and profiles provided by openscap container image here (for the following discussion and tracking of other PRs related to that): https://github.com/OpenSCAP/openscap-daemon/issues/122

jan-cerny commented 6 years ago

@matusmarhefka Thank you very much! Great!.