Container image install now also sets image name into /etc/atomic.d/openscap

[matusmarhefka]

• When installing image using 'atomic install IMAGE_NAME', IMAGE_NAME was not added into configuration file /etc/atomic.d/openscap. This commit corrects it and properly installs the specified container image.

Fixes RHBZ 1440173

[pep8speaks]

Hello @matusmarhefka! Thanks for updating the PR.

• In the file generate-dockerfile.py, following are the PEP8 issues :

Line 10:80: E501 line too long (118 > 79 characters) Line 11:80: E501 line too long (222 > 79 characters) Line 13:80: E501 line too long (229 > 79 characters) Line 15:80: E501 line too long (92 > 79 characters) Line 37:13: E203 whitespace before ':' Line 38:11: E203 whitespace before ':' Line 46:80: E501 line too long (84 > 79 characters) Line 74:80: E501 line too long (88 > 79 characters) Line 79:13: E128 continuation line under-indented for visual indent Line 81:9: E128 continuation line under-indented for visual indent Line 83:9: E128 continuation line under-indented for visual indent Line 85:9: E128 continuation line under-indented for visual indent Line 85:80: E501 line too long (81 > 79 characters) Line 86:80: E501 line too long (80 > 79 characters) Line 87:9: E128 continuation line under-indented for visual indent Line 88:80: E501 line too long (88 > 79 characters) Line 89:9: E128 continuation line under-indented for visual indent Line 91:9: E128 continuation line under-indented for visual indent Line 93:61: E711 comparison to None should be 'if cond is not None:' Line 94:9: E125 continuation line with same indent as next logical line Line 94:9: E128 continuation line under-indented for visual indent Line 103:80: E501 line too long (82 > 79 characters) Line 104:80: E501 line too long (82 > 79 characters) Line 129:34: E711 comparison to None should be 'if cond is not None:' Line 133:80: E501 line too long (80 > 79 characters) Line 134:80: E501 line too long (80 > 79 characters) Line 135:80: E501 line too long (140 > 79 characters) Line 147:29: E711 comparison to None should be 'if cond is not None:' Line 152:80: E501 line too long (84 > 79 characters) Line 163:26: E231 missing whitespace after ',' Line 164:32: E711 comparison to None should be 'if cond is not None:' Line 185:80: E501 line too long (106 > 79 characters) Line 188:80: E501 line too long (90 > 79 characters) Line 192:80: E501 line too long (88 > 79 characters) Line 210:80: E501 line too long (90 > 79 characters) Line 216:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated on November 03, 2017 at 10:19 Hours UTC

[matusmarhefka]

Commit 51c74b9 is using a placeholder/token in container/openscap which is then replaced by container/install.sh