Generated Dockerfile optimization.

[matejak]

The aim is to squash multiple statements into one, so the resulting image has smaller size and contains fewer layers.

Statements to handle:

• [x] ADD
• [x] ENV
• [x] LABEL
• [x] RUN (the trickiest one)

[openscap-ci]

Can one of the admins verify this patch?

[pep8speaks]

Hello @matejak! Thanks for updating the PR.

• In the file generate-dockerfile.py, following are the PEP8 issues :

Line 16:80: E501 line too long (118 > 79 characters) Line 17:80: E501 line too long (222 > 79 characters) Line 19:80: E501 line too long (229 > 79 characters) Line 21:80: E501 line too long (92 > 79 characters) Line 23:80: E501 line too long (179 > 79 characters) Line 49:80: E501 line too long (84 > 79 characters) Line 76:80: E501 line too long (88 > 79 characters) Line 92:80: E501 line too long (81 > 79 characters) Line 185:80: E501 line too long (81 > 79 characters) Line 271:80: E501 line too long (80 > 79 characters) Line 272:80: E501 line too long (80 > 79 characters) Line 341:80: E501 line too long (82 > 79 characters) Line 355:80: E501 line too long (80 > 79 characters) Line 364:80: E501 line too long (98 > 79 characters) Line 383:80: E501 line too long (94 > 79 characters)

Comment last updated on February 02, 2018 at 16:18 Hours UTC

[jan-cerny]

@openscap-ci add to whitelist

[mpreisler]

• bzip2 package was removed as Python depends on it, so it is always present.

IMO if we used bzip2 directly we should depend on it directly. Python impl can change and then this whole thing breaks.

[jan-cerny]

This works OK for me.