OpenSCAP / openscap-daemon

Manages continuous scans of your infrastructure
https://www.open-scap.org/tools/openscap-daemon
GNU Lesser General Public License v2.1
106 stars 32 forks source link

scrape_profiles does not have enough arguments #137

Closed jan-cerny closed 6 years ago

jan-cerny commented 6 years ago

In oscap_helpers.py, function scrape_profiles has 5 arguments, but sometimes only 1st, 4th and 5th are given. The 2nd and 3rd argument are missing.

eg.

I think this will cause errors that not enough arguments were provided.

Please see https://github.com/OpenSCAP/openscap-daemon/blob/master/openscap_daemon/oscap_helpers.py

mpreisler commented 6 years ago

Yeah, good catch. https://github.com/OpenSCAP/openscap-daemon/pull/117 caused a regression in all use-cases of openscap-daemon except atomic scan, we need to fix this ASAP

the function no longer works for XCCDF files, only for datastreams