Closed ybznek closed 8 years ago
Hello @ybznek,
I have been playing with the atomic scan with deamon with patches from this PR. It looks working well for me.
I use updated Fedora 23 minimal virtual machine, Python 3, openscap-1.2.8-1.fc23.x86_64, docker-1.9.1-6.git6ec29ef.fc23.x86_64, atomic-1.8-3.gitcc5997a.fc23.x86_64
I have 6 images and 2 running containers, I have tried atomic scan --images
and atomic scan --containers
and atomic scan --all
several times. No exception or error occured. Also I haven't found anything suspicious in the journalctl.
Overall it looks good to me. Thank you.
Yes, but we still should find better solution. I don't know if we should merge it. After merge nobody will fix it later.
Seems to be working with rhel7 and fedora23. Possible issues with Rawhide we can fix later.
@ybznek Great! Thank you.
Ok, guys. I think it will be a step forward if we merge it.
I have heard well the reasons against having this temporary solution. The argument (from @mpreisler , @jan-cerny, and @myself) against have more merits in my view. However, we are in situation when this functionality is in a spotlight right now, so I think it will help us to merge this and have the atomic scan
working in Fedora.
In this PR are many things, because it is lot of easier to manage / test if one fix doesn't incompatible with some other.
I am still testing/working on it. But you can review the changes.
This PL: