OpenSCAP / openscap-report

Tool for generating a report from results of oscap scan.
Other
19 stars 9 forks source link

Fix XCCDF support #134

Closed Honny1 closed 1 year ago

Honny1 commented 1 year ago

This PR fixes crashes when using the XCCDF report.

How to reproduce the problem: Use oscpa-report with XCCDF results.
For example: oscap-report < tests/test_data/xccdf-report.xml

The crashes were caused by a missing part of the if condition. To avoid this problem, I created integration tests with all test files. And I discovered problems:

jan-cerny commented 1 year ago

How can we reproduce the crash?

How will you prevent the bug from happening in future again?

Honny1 commented 1 year ago

Changes:

Honny1 commented 1 year ago

Changes:

Nothing has changed since @jan-cerny's last comment.

jan-cerny commented 1 year ago

I have verified that it still works OK after the rebase.