search

OpenSCAP / openscap-report

Tool for generating a report from results of oscap scan.
Other
17 stars 9 forks source link

Present references in a table #217

Closed jan-cerny closed 7 months ago

jan-cerny commented 8 months ago

We will sort and show the references grouped by reference target. The well-known references will be labeled. This makes the "References" section of rule detail actually useful.

For example:

image

Fixes: https://github.com/OpenSCAP/openscap-report/issues/154

pep8speaks commented 8 months ago

Hello @jan-cerny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-12-06 12:48:06 UTC
evgenyz commented 7 months ago

It really feels like the code (and developers' personal preferences) is asking for the line length limit to be 120 instead of 100.

jan-cerny commented 7 months ago

Not really. All the lines that are flagged as too long are in the list of URLs (KNOWN_REFERENCES) because the URLs are long. I think we can waive this occurrence as a special case. I think it's more useful to keep the URLs as they are instead of splitting them by a backlash because if they are kept as they are they can be easily identified by grep when a need to update them arise.

jan-cerny commented 7 months ago

I have add comments for the pylint tool

jan-cerny commented 7 months ago

I have extend the condition to account empty strings in href.