Improve layout of test details window

OpenSCAP / openscap-report

Tool for generating a report from results of oscap scan.

Other

19 stars 9 forks source link

Improve layout of test details window #239

Closed jan-cerny closed 2 months ago

jan-cerny commented 3 months ago

make the layout more compact to show all related data at a single place
For OVAL objects, create a table where each child element is represented as a table row
OVAL object child elements tag name is shown as first column in the row
OVAL object child elements text data shown as second column in the row
OVAL object child elements attributes are shown as labels
OVAL states and OVAL variables are presented in a similar way as OVAL objects as described above
make sure the test details window is standalone

Any suggestions are welcome. I would appreciate advice on the classes of the HTML elements. Feel free to come up with layout suggestions. I'm also interested in you experience in more complex OVAL tests. Please try it out and report back.

jan-cerny commented 2 months ago

One big problem with this PR that I found is that now it doesn't show the direct child elements of local_variable elements (eg. arithmetic, time_difference) and it jumps directly to grandchildren elements (eg. object_component, literal_component).

In the current main branch it is also not ideal but there is at least the tag name printed.

I think the name of the direct child element should be a special row in the "OVAL variable" table. It's also important to add their attributes because for example the arithmetic element has the arithmetic operation in the arithmetic_operation attribute.

matusmarhefka commented 2 months ago

LGTM, I reviewed the code changes and tested it on the latest Fedora.

jan-cerny commented 2 months ago

One big problem with this PR that I found is that now it doesn't show the direct child elements of local_variable elements (eg. arithmetic, time_difference) and it jumps directly to grandchildren elements (eg. object_component, literal_component).

In the current main branch it is also not ideal but there is at least the tag name printed.

I think the name of the direct child element should be a special row in the "OVAL variable" table. It's also important to add their attributes because for example the arithmetic element has the arithmetic operation in the arithmetic_operation attribute.

this is solved in the 2 latest comments

jan-cerny commented 2 months ago

I think that more visual improvements should be done in a separate PR to not increase the size of this PR.