Rework test suite - Githubissues

OpenSCAP / oval-graph

Understand OVAL results in a blink of an eye

Apache License 2.0

34 stars 19 forks source link

Rework test suite #200

Closed Honny1 closed 3 years ago

Honny1 commented 3 years ago

This PR is the first part of a rework of the test suite.

Remove duplicate code form tests
Changes how are loaded path
Reworks tests of OVAL evaluation
Reworks tests of OVAL tree
Reworks tests of ARF XML parser

pep8speaks commented 3 years ago

Hello @Honny1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-08-04 12:42:47 UTC

jan-cerny commented 3 years ago

In past we had bad experience with symlinks. They were used in ComplianceAsCode/content. Some people clones the repository without symlinks, some people break the symlinks during copying, some editors didn't support them, etc. I would prefer avoid using symlinks.

Honny1 commented 3 years ago

I will remove symlinks in #207.

jan-cerny commented 3 years ago

Hi, it's amazing, but next time please create small PRs to make it easier to review ;)