search

OpenSCAP / scap-workbench

SCAP Scanner And Tailoring Graphical User Interface
https://www.open-scap.org/tools/scap-workbench
GNU General Public License v3.0
226 stars 64 forks source link

Windows Release Guide confusing instructions #152

Open jan-cerny opened 6 years ago

jan-cerny commented 6 years ago

https://github.com/OpenSCAP/scap-workbench/wiki/Windows-build-and-installer-guide

Section 4. Get ssh.exe & win-ssh-askpass.exe says: Do not get anything else from the old MSI, everything else must be fresh built!

Then Section 5. Get libraries using mingw-bundledlls says: We will use previous release to get missing libraries.

I would prefer to explicitly list those libraries that are missing. I would suggest to copy them already in step 4. If you run mingw-bundledlls and you don't already have the missing libraries copied from previous release you get a traceback.

It might happen that somebody will understand the release guide and mingw-bundledlls wrong and will copy more libraries than only the missing libraries.

matejak commented 6 years ago

@WesleyCeraso, who released the previous workbench mentioned, that he took libraries from the previous release. However, rebuilding it is probably better. We will investigate this, but using the previous release is the quick way to go that should work.

jan-cerny commented 6 years ago

Ok, thanks. To clarifiy this: There are 2 types of bundled libraries in SCAP Workbench for Windows: 1) libraries that are dependecies of oscap.exe. It is libopenscap.dll that we rebuilt and also libraries than come from MinGW installation on Fedora. All of them are obtained by migw-bundledlls --copy oscap.exe 2) missing libraries that are dependencies of ssh.exe and win-ssh-askpass.exe. We copy these libraries from the old installer. They're not properly documented in the Windows Release Guide.