Closed cipherboy closed 3 years ago
We are struggling to get the OpenSCAP 1.3 itself there... But, it might be a good idea to add GH actions CI based on Ubuntu.
@evgenyz Unless there's a need (in which case, I can try advocating for it), it got into Debian testing so when h+1 (21.04+1 == 21.10) is cut, it'll be there. I might be able to get it back to 21.04, but it'd be a tough sell to get back to 20.04 (last LTS) or 20.10 IMO. Sorry :/
What's the rationale for shipping 1.3 back to e.g., 20.04?
Also related, scap-workbench
was removed from Debian, so for recent Ubuntu releases, it isn't shipping at all. I wanted to use it, so I figured I'd start here and then see if I could find one of the original Debian maintainers to update it :)
@evgenyz Unless there's a need (in which case, I can try advocating for it), it got into Debian testing so when h+1 (21.04+1 == 21.10) is cut, it'll be there. I might be able to get it back to 21.04, but it'd be a tough sell to get back to 20.04 (last LTS) or 20.10 IMO. Sorry :/
What's the rationale for shipping 1.3 back to e.g., 20.04?
It's not like we are trying to push 1.3 backwards, we just have a lot of bugs related to the usage of oscap 1.2 with contemporary security content (with predictable problems) and would prefer to have it updated.
@evgenyz If this builds, feel free to merge it :)
But even reordering the main.yml
file, MacOS is building before Ubuntu and I'm running out of patience debugging MacOS issues... :)
Well, MacOS still doesn't build. Thoughts?
Well, MacOS still doesn't build. Thoughts?
The errors appear to be around CMake and CMake's inability to correctly find what it needs from the brew install. Adding an export PATH
most likely won't solve Cmake problems.
Hey @redhatrises! Nice to see you :) Saw you left -- I also did.
The errors appear to be around CMake and CMake's inability to correctly find what it needs from the brew install. Adding an export PATH most likely won't solve Cmake problems.
Hmmm I found a GH issue that seems to be another app having issues building on MacOS. https://github.com/robotology/robotology-superbuild/issues/4 -- hopefully the environment variables they suggest setting there will help.
@evgenyz Do you want to take this without working MacOS image? I tried to make some updates to make it work but ultimately failed. Ubuntu image passes though... Perhaps save MacOS work for another PR?
test this please
@matejak Do you want me to drop the OS X CI portion of this PR? @mab879 has a Mac and mentioned he was trying to build scap-workbench
on it so if you'd prefer, could see if he's willing to open a PR fixing CI once it builds locally.
@matejak Do you want me to drop the OS X CI portion of this PR? @Mab879 has a Mac and mentioned he was trying to build
scap-workbench
on it so if you'd prefer, could see if he's willing to open a PR fixing CI once it builds locally.
Yes, please drop that part - the benefit of the modification is not obvious, as the CI fails anyway.
LGTM, thanks!
Thanks for the merge, @matejak!
Signed-off-by: Alexander Scheel <alex.scheel@canonical.com>
Starting slow again :-)
Do we want to drop the
master
branch and recreate it from currentv1-2
branch (or later create av1-3
branch instead)?I haven't yet checked with the current Debian maintainers to see if they're still interested in packaging
scap-workbench
. It was last present in Buster, at an earlier v1.1 version. That means it was last in 18.04 and hasn't been present since.Is anyone here in contact with them by any chance?