With the async behavior of Scanner (and its interactions in MainWindow),
it isn't obvious that Session can't be non-NULL here. Hence it is
probably better to move the session use into the if-guard.
Resolves: #262
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Looks like @mpreisler originally wrote the if-guard but didn't mention why it was necessary either :-)
evgenyz
commented
3 years ago
With the async behavior of Scanner (and its interactions in MainWindow), it isn't obvious that Session can't be non-
NULLhere. Hence it is probably better to move the session use into the if-guard.Resolves: #262
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>Looks like @mpreisler originally wrote the if-guard but didn't mention why it was necessary either :-)