search

OpenSIPS / opensips

OpenSIPS is a GPL implementation of a multi-functionality SIP Server that targets to deliver a high-level technical solution (performance, security and quality) to be used in professional SIP server platforms.
https://opensips.org
Other
1.22k stars 570 forks source link

[BUG] Tracer messages out of order #1891

Open vladpaiu opened 4 years ago

vladpaiu commented 4 years ago

Hello,

Commit aaa6b6867763a564d5b53460ab3f23a4033272a6 introduced a bug related to the ordering of the tracing messages - since the ACK callback gets called before TMCB_RESPONSE_IN, when tracing via HEP the output PCAPs are screwed, since the ACK is shown before the actual reply.

Regards, Vlad

stale[bot] commented 4 years ago

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

stale[bot] commented 4 years ago

Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details.

bogdan-iancu commented 4 years ago

naughty bot...

stale[bot] commented 4 years ago

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

bogdan-iancu commented 4 years ago

@vladpaiu , I agree, the commit did change the order, but the tricky question is what should be the right approach ? If we trace the reply first, we may end up with delays at SIP level for sending back the ACK (so the SIP may be affected and delayed by the tracing operation). If we trace the reply after sending back the ACK, we mess up with the tracing (ACK will be trace before the actual reply). Part of the problem is that the ACK tracing is built into the sending function, you cannot send the ACK and trace it later (especially because the ACK buffer is ephemeral)

stale[bot] commented 4 years ago

Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days.

stale[bot] commented 4 years ago

Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details.

stale[bot] commented 3 years ago

Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details.

nikbyte commented 3 years ago

I expect the same issue. Please, don't close.

gmaruzz commented 3 years ago

+1

bogdan-iancu commented 3 years ago

Unfortunately there is no easy solution here, see my prev comment

liviuchircu commented 2 months ago

A fix attempt was pushed to master today, let's see if it holds and we can backport it down to 3.2 if there is positive feedback.