OpenSIPS / opensips

OpenSIPS is a GPL implementation of a multi-functionality SIP Server that targets to deliver a high-level technical solution (performance, security and quality) to be used in professional SIP server platforms.
https://opensips.org
Other
1.27k stars 578 forks source link

[FEATURE] Allow the setting of reinvite_ping_interval on a per call basis #2360

Open dovi5988 opened 3 years ago

dovi5988 commented 3 years ago

We would like to be able to update the value of reinvite_ping_interval on a per call basis.

Currently we have some carriers with less then ideal rules in their firewall. In order to make sure that they keep listening out for our BYE's we need to send a re-invite every 55 seconds. This is causing issues with our other providers that don't like getting re-invites so often. (We recently had a case where we and our carriers upstream sent a re-invite with in the same 100 ms, this caused their switch to send 491's to both sides indefinitely). We would like a way to set a variable that will change the timer for the call. I think it should work like this.

1) In the configs for the dialog module we should be able to set the default as we can now (e.g. modparam("dialog", "reinvite_ping_interval", 55)) 2) We should then be able to set a variable when handling the initial request to set what it should be. So for instance where we know a carrier normally works fine we would set it to 0 which should mean never. Or we could set it to 3600 so it would happen once an hour as opposed to every 55 seconds.

bogdan-iancu commented 3 years ago

@dovi5988 , what about setting the reinvite_ping_interval modparam to 55 and when you have call to problematic carriers use the Rr flags, while for normal carriers you simply do not use those flags in create_dialog (and no pinging will be done).

dovi5988 commented 3 years ago

@bogdan-iancu We do want some pinging to be done (say every 1800 seconds) we just don't want it as often as we do it now for the problematic carriers. I also tried using pP inpleace of rR but strangely enough some carriers don't respond to Options Packets.

bogdan-iancu commented 3 years ago

gotcha !

dovi5988 commented 3 years ago

So where does this request stand?