Closed StellaTeam closed 10 months ago
I've just fixed the archives, thanks for pointing it out.
Hello @razvancrainea
Thank you for the tar fix but the problem is not solved as patch errors are still present and so files are not patched as expected.
Just now, with the new archive, messages are the same. So, the wolfssl leak won't be solved.
There is probably a mismatch between the patch and included wolfSSL libs, for the patch to fail.
Unreversed patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file src/internal.c.rej Unreversed patch detected! Skipping patch. 3 out of 3 hunks ignored -- saving rejects to file src/ssl.c.rej make[4]: [Makefile:41: clean-wolfssl-lib] Error 1 (ignorée)
Thank you for your coming fixes.
Hello,
We're unable to compile latest 3.4.2 version of OpenSIPS. File wolfssl-internal-memleak-fix.patch is missing in the tar.gz file.
If wolfssl-internal-memleak-fix.patch from https://raw.githubusercontent.com/OpenSIPS/opensips/3.4.2/modules/tls_wolfssl/lib/patches/wolfssl-internal-memleak-fix.patch is manually added to source files, the patch is rejected with this message:
Unreversed patch detected! Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file src/internal.c.rej Unreversed patch detected! Skipping patch. 3 out of 3 hunks ignored -- saving rejects to file src/ssl.c.rej make[4]: [Makefile:41: clean-wolfssl-lib] Error 1 (ignorée)
And so, the sources compile well once file is added, but the compiled files don't contain every changes contained in the patch, so, the leak won't be fixed.
To Reproduce
/bin/sh: 1: cannot open lib/patches/wolfssl-internal-memleak-fix.patch: No such file
Expected behavior
Compile successfully without errors.
Thank you